Useless or incorrect tests.
[rsc] --rw-rw-r-- M 129339 glenda sys 9496 Dec 12 07:21 sys/src/9/ip/icmp.c
/n/sourcesdump/2005/1212/plan9/sys/src/9/ip/icmp.c:369,375 -
/n/sourcesdump/2005/1213/plan9/sys/src/9/ip/icmp.c:369,375
ipoput4(icmp->f, r, 0, MAXTTL, DFLTTOS, nil);
break;
case Unreachable:
- if(p->code > 5 || p->code < 0)
+ if(p->code > 5)
msg = unreachcode[1];
else
msg = unreachcode[p->code];
[rsc] --rw-rw-r-- M 129339 presotto sys 18083 Dec 12 07:21 sys/src/9/ip/icmp6.c
/n/sourcesdump/2005/1212/plan9/sys/src/9/ip/icmp6.c:749,755 -
/n/sourcesdump/2005/1213/plan9/sys/src/9/ip/icmp6.c:749,755
break;
case UnreachableV6:
- if(p->code > 4 || p->code < 0)
+ if(p->code > 4)
msg = unreachcode[icmp6_unkn_code];
else
msg = unreachcode[p->code];
[rsc] --rw-rw-r-- M 129339 glenda sys 26923 Dec 12 07:21 sys/src/9/ip/il.c
/n/sourcesdump/2005/1212/plan9/sys/src/9/ip/il.c:563,569 -
/n/sourcesdump/2005/1213/plan9/sys/src/9/ip/il.c:563,569
v4tov6(laddr, ih->dst);
if((csum = ptclcsum(bp, IL_IPSIZE, illen)) != 0) {
- if(ih->iltype < 0 || ih->iltype > Ilclose)
+ if(ih->iltype > Ilclose)
st = "?";
else
st = iltype[ih->iltype];
/n/sourcesdump/2005/1212/plan9/sys/src/9/ip/il.c:586,592 -
/n/sourcesdump/2005/1213/plan9/sys/src/9/ip/il.c:586,592
if(ic->state == Illistening){
if(ih->iltype != Ilsync){
qunlock(il);
- if(ih->iltype < 0 || ih->iltype > Ilclose)
+ if(ih->iltype > Ilclose)
st = "?";
else
st = iltype[ih->iltype];
[rsc] --rw-rw-r-- M 129339 presotto sys 28760 Dec 12 07:22 sys/src/9/pc/etherga620.c
/n/sourcesdump/2005/1212/plan9/sys/src/9/pc/etherga620.c:1056,1062 -
/n/sourcesdump/2005/1213/plan9/sys/src/9/pc/etherga620.c:1056,1062
static int
ga620reset(Ctlr* ctlr)
{
- int cls, csr, i;
+ int cls, csr, i, r;
if(ga620detach(ctlr) < 0)
return -1;
/n/sourcesdump/2005/1212/plan9/sys/src/9/pc/etherga620.c:1095,1102 -
/n/sourcesdump/2005/1213/plan9/sys/src/9/pc/etherga620.c:1095,1103
* Snarf the MAC address from the serial EEPROM.
*/
for(i = 0; i < Eaddrlen; i++){
- if((ctlr->ea[i] = at24c32r(ctlr, 0x8E+i)) == -1)
+ if((r = at24c32r(ctlr, 0x8E+i)) == -1)
return -1;
+ ctlr->ea[i] = r;
}
/*
[jmk] --rw-rw-r-- M 129339 glenda sys 2494 Dec 12 13:16 sys/src/9/port/sd.h
/n/sourcesdump/2005/1212/plan9/sys/src/9/port/sd.h:25,31 -
/n/sourcesdump/2005/1213/plan9/sys/src/9/port/sd.h:25,31
struct SDunit {
SDev* dev;
int subno;
- uchar inquiry[256]; /* format follows SCSI spec */
+ uchar inquiry[255]; /* format follows SCSI spec */
uchar sense[18]; /* format follows SCSI spec */
SDperm;
|